Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wait using kstatus #3043

Merged
merged 12 commits into from
Oct 9, 2024
Merged

feat: wait using kstatus #3043

merged 12 commits into from
Oct 9, 2024

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Sep 27, 2024 •
edited
Loading

Description

This PR changes the existing wait functionality to have use kstatus after helm wait

Related Issue

Fixes #2973
Fixes #2855

Checklist before merging

@netlify Netlify
Copy link

netlify bot commented Sep 27, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit c816251
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/670591123cf441000847dc49

@AustinAbro321 AustinAbro321 changed the title feat: wait using health checks (kstatus) feat: wait using kstatus Sep 27, 2024
@phillebaba
Copy link
Member

I think it would be good to have new packages be in internal instead of pkg initially if there isn't an explicit interest of exporting the functionality for others to use outside of Zarf.

@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 39.02439% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager/helm/chart.go 0.00% 22 Missing ⚠️
src/internal/healthchecks/healthchecks.go 88.88% 1 Missing and 1 partial ⚠️
src/pkg/packager/deploy.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/deploy.go 5.86% <0.00%> (-3.37%) ⬇️
src/internal/healthchecks/healthchecks.go 88.88% <88.88%> (ø)
src/internal/packager/helm/chart.go 13.25% <0.00%> (-1.16%) ⬇️

@AustinAbro321
dco
de3e6b4 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
add health checks module
a5e1798 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
revise comment
68ac94e 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review October 1, 2024 19:10
@AustinAbro321 AustinAbro321 requested review from a team as code owners October 1, 2024 19:10
@AustinAbro321 AustinAbro321 mentioned this pull request Oct 2, 2024
Closed
2 tasks
@AustinAbro321
update docs
d713979 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
change timeout logic
a5cbe62 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
phillebaba
phillebaba reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@phillebaba phillebaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another small comment I would move the health check package out of packager.

src/internal/packager/healthchecks/healthchecks_test.go Outdated Show resolved Hide resolved
@AustinAbro321
inline function
0871213 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
move healthchecks outside of packager
48057fb 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
update status
093ddf1 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 mentioned this pull request Oct 2, 2024
Merged
2 tasks
@AustinAbro321
use context in helm over timeout
18ce5a0 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
Merge branch 'main' into introduce-wait-key
00a37f2
@AustinAbro321
simplify context
2bbdfd5 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321
don't cancel twice
c816251 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@phillebaba phillebaba added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 609bdc1 Oct 9, 2024
26 checks passed
@phillebaba phillebaba deleted the introduce-wait-key branch October 9, 2024 09:19
mjnagel pushed a commit to mjnagel/zarf that referenced this pull request Oct 21, 2024
@AustinAbro321 @mjnagel
feat: wait using kstatus (zarf-dev#3043)
87d4cef 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillebaba phillebaba phillebaba approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
2 participants
@AustinAbro321 @phillebaba